Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the test data stored by das fs healthcheck #2513

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

Tristan-Wilson
Copy link
Member

@Tristan-Wilson Tristan-Wilson commented Jul 23, 2024

For some installations, if they had already stored 65000 expiry index entries for the old health check data, simply setting the expiry time to the start of epoch isn't enough to fix the health check for them since it already has 65000 entries and start of epoch would be another entry, exceeding the max inode links.

Simply changing the test data preimage fixes this becauese it will be stored at a different hash.

For some installations, if they had already stored 65000 expiry index
entries for the hold health check data, simply setting the expiry time
to the start of epoch isn't enough to fix the health check for them
since it already has 65000 entries and start of epoch would be another
entry, exceeding the max inode links.

Simply changing the test data preimage fixes this becauese it will be
stored at a different hash.
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 23, 2024
Copy link
Contributor

@amsanghi amsanghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson Tristan-Wilson merged commit 54b48bb into master Jul 24, 2024
13 checks passed
@Tristan-Wilson Tristan-Wilson deleted the das-change-healthcheck-data branch July 24, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants